[PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

Caibin Chen tigersoldi at gmail.com
Wed Jul 31 14:43:42 CDT 2013


There are at least 3 more interfaces to be implemented, should I put
them in richole.c as well?

2013/7/31 Alexandre Julliard <julliard at winehq.org>:
> Caibin Chen <tigersoldi at gmail.com> writes:
>
>> Hi Alexandre,
>>
>> I think it make sense to have a separate file for ITextDocument. It
>> will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's
>> convention to not have separate files for separate implementations, I
>> can merge the txtrng.[ch] and txtsel.[ch] that introduced in patch 2
>> and 3 into txtdoc.[ch]
>
> It's already defined and used in richole.c. If at some point it becomes
> too large it can be moved to a different file, but introducing a new
> file and then removing that stuff from richole.c makes a mess of the
> history.
>
> --
> Alexandre Julliard
> julliard at winehq.org



More information about the wine-devel mailing list