[PATCH 2/5] wined3d: Handle fog_start==fog_end with table fog(try 2)

Henri Verbeet hverbeet at gmail.com
Tue Jun 18 05:53:18 CDT 2013

On 18 June 2013 14:19, Stefan Dösinger <stefan at codeweavers.com> wrote:
> Am 2013-06-18 09:12, schrieb Henri Verbeet:
>> Which of those is affected by the quirk? I think all of those
>> except r200 should be able to do GLSL, but you say r200 is the only
>> one that doesn't pass the tests.
> All Linux drivers. The OSX drivers I tested get the special case right.
That's not really what I meant. Unless you explicitly disable the GLSL
backend and create an unsupported configuration, r200 should be the
only one of the above where you'll see the driver bug without the
quirk. (And that one is only supported by Mesa anyway, so there should
be no reason to not just fix the driver instead.)

>> You may be able to convince me that this is a good idea, but so far
>> I don't think it's worth all the extra code.
> My motivation is to make the tests pass on as many configurations as
> possible.
Sure, up to a point. Obvious bug fixes are clearly worth it, but I
think workarounds for driver bugs in unsupported configurations are
harder to justify.

> I can deal with ARB in another way, by implementing the fog equation
> myself instead of using #option ARB_fog_linear. That would throw
> pre-sm2 hardware under the bus though.
Yeah, we probably don't want that. I think the value of the ARB
program backend is limited, but it's main target should be pre-SM2
hardware that can't do GLSL. (And potentially still has dedicated fog

More information about the wine-devel mailing list