[PATCH] winetest: Add support for wineconsole output

Fabian Ebner f.ebner94 at gmail.com
Thu Jun 20 11:15:05 CDT 2013


Am 20.06.2013 17:55, schrieb Bruno Jesus:
> On Thu, Jun 20, 2013 at 12:42 PM, Fabian Ebner <f.ebner94 at gmail.com> wrote:
>> Allow winetest to output stuff inside a wineconsole.
>> Fixes http://bugs.winehq.org/show_bug.cgi?id=28191
>> ---
>>   programs/winetest/gui.c      |  6 +++---
>>   programs/winetest/main.c     |  2 +-
>>   programs/winetest/util.c     | 25 +++++++++++++++++++++++++
>>   programs/winetest/winetest.h |  1 +
>>   4 files changed, 30 insertions(+), 4 deletions(-)
>> +    //No logfile means printing to stdout
Ok, thanks
> C++ comments are not allowed AFAIK.
>
>> +    if (!logfile) {
The surrounding code uses this style when it is an if or a while, when 
it's a function it uses new-line {.
But there are only two other occurences of {}-braces, should I change 
them with my patch and use new-line all along?
> You should use the coding style of the surrounding code, it looks like
> the rest of the file uses the { in the next line, I may be wrong about
> this.
>
> Best wishes,
> Bruno




More information about the wine-devel mailing list