[PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

Christian Costa titan.costa at gmail.com
Tue Jun 25 04:05:57 CDT 2013

2013/6/25 Henri Verbeet <hverbeet at gmail.com>

> On 24 June 2013 16:44, Matteo Bruni <matteo.mystral at gmail.com> wrote:
> > @@ -1673,6 +1673,8 @@ struct texture_stage_op
> >      unsigned                aarg2 : 8;
> >      unsigned                aarg0 : 8;
> >
> > +    DWORD                   constant;
> > +
> >      struct color_fixup_desc color_fixup;
> >      unsigned                tex_type : 3;
> >      unsigned                dst : 1;
> >
> > You don't need this if you use uniforms.
> > Also adding a test would be nice probably.
> >
> Yeah, that's the main issue. We don't want a shader for every possible
> set of per-stage constant values. The one you missed is that if we
> implement this, we should also set the appropriate caps bit.

Spin Tires does not seem to check this caps. That's why I missed it first.

> The most obvious issue is of course the subject line. Sure, typos
> happen, but it's just plain sloppy.

It's a typo yes. You can easy deduced this with the patch description.

> At least try to pretend you put
> some effort into making sure the patch is as good as it can be before
> submitting it.

I could have send the patch to wine-devel first but would I get something
longer that "several issues" as feedback?
I can certainly improve my patches and you can certainly improve your way
of giving feedback but that would be great
if you could avoid this kind of commentary. This is not usefull. At least
for me. For technical stuff you can be as verbose as you want. I'm full
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130625/9e30f318/attachment-0001.html>

More information about the wine-devel mailing list