Need help with a rsaenh bug
juan.lang at gmail.com
Fri Jun 28 11:34:36 CDT 2013
On Fri, Jun 28, 2013 at 9:16 AM, Qian Hong <fracting at gmail.com> wrote:
> Dear Juan,
> Thanks for reviewing!
> On Fri, Jun 28, 2013 at 11:31 PM, Juan Lang <juan.lang at gmail.com> wrote:
> > It's more in line with most C code to use !memcmp(...) instead of
> > memcmp(...)==0. I find it easier to scan, anyway, as I've gotten used to
> > comparisons to check equality in memcmp, strcmp, and variants.
> I'm glad to change, but the surrounding code use memcmp(...)==0
> already, should I change that as well?
Ah. Thanks for following the existing style then :-/ No, don't bother
changing the existing code. I leave it up to you whether to follow my
suggestion or ignore it, either is fine in this case.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the wine-devel