gdiplus/tests: Skip the tests if unable to load the TIFF image.

Dmitry Timoshkov dmitry at baikal.ru
Mon Mar 4 09:54:48 CST 2013


Nikolay Sivov <bunglehead at gmail.com> wrote:

> >> The goal of the Wine tests is to document the Windows behavior that
> >> Windows applications expect.
> > Skipping a test because your VM is broken doesn't qualify as a documentation
> > of Windows behaviour.
> Why is that broken?

It's broken because the test is supposed to pass.

> Tests results could be submitted by anyone running 
> Windows with or without updates.

Sending broken results doesn't mean that the tests need to be fixed.

> Currently test just returns, with this patch it prints a possible 
> reason. What's a problem?

If that's supposed to be a way how a failing (under official Wine testbot)
test will be "fixed" in future that's not acceptable.

-- 
Dmitry.



More information about the wine-devel mailing list