[0/10] Launcher app bundles on OS X

C.W. Betts computers57 at hotmail.com
Mon Mar 18 15:13:26 CDT 2013

A quick glance at the source revealed that you removed static from some functions. Why? If a function isn't being called outside a source file, it's better to have it be static. This includes functions referenced in structs (but not the structs themselves).

A more seasoned developer is welcome to correct me if I'm wrong.
On Mar 17, 2013, at 11:18 AM, Per Johansson <per at morth.org> wrote:

> I'm resending this now after testing it with the Mac driver.
> They work well together, the launcher bundle will first briefly
> appear in the dock, then exit, and the mac driver icon appears.
> It's split it up into parts for easier review. I've also tried
> to make sure that even if e.g. part 6 fails review, part 1 - 5
> can still be applied.
> File type associations are not included because I plan to move
> that code into the mac driver but haven't gotten around to it yet.
> Regards,
> -- 
> Per Johansson

More information about the wine-devel mailing list