[PATCH] dlls/gdi32/fretype.c: Avoid division by zero.
Max TenEyck Woodbury
max at mtew.isa-geek.net
Sat May 4 19:05:25 CDT 2013
On 05/04/2013 07:50 PM, Hin-Tak Leung wrote:
>
> I'd like to mention two things:
>
> - there were(are?) overflows/underflows within Freetype itself, up to
> and including 2.4.11 - the fixes went into trunk, but AFAIK 2.4.12
> isn't release yet. That's specifically affect 32-bit platform, and
> emulated styles (i.e. where the application requires a font style
> which cannot be provided by any one font, but needed to be
> "synthesized" by fontconfig and freetype).
>
> - there a few well-known "open-source" fonts which microsoft's gdiplus
> does not like and crash on them, but nonetheless, windows users
> never encounter the problems, because they typically have the
> proprietary MS equivalent, and therefore do not need those fonts at
> all.
>
> I suggest - (1) check out freetype trunk to see if it helps, or at
> least, patch your freetype with those fixes from end of January; (2)
> modify the "Avoid division by zero" patch to emit the font's typeface
> name whenever the condition occur, and just run it on the affected
> system to see which typeface wine doesn't like?
>
> Does this sound reasonable?
>
Actually quite reasonable, particularly the part about identifying the
troublesome font. However, I doubt that it would be accepted by the others.
More information about the wine-devel
mailing list