[PATCH] dlls/gdi32/fretype.c: Avoid division by zero.
Akihiro Sagawa
sagawa.aki at gmail.com
Sat May 4 21:56:14 CDT 2013
On Sat, 04 May 2013 19:13:07 -0400, Max TenEyck Woodbury wrote:
> I have no objection to someone writing an alternative patch and backing
> this one out when that patch goes in, but until then, this patch, or
> something like it, needs to be applied. With wine throwing the
> exception, some Apps are going to fail that would not fail otherwise.
> That is definitely a 'Bad Thing' and should be fixed ASAP (like right
> now)!
Hi,
I'm an author of the SCALE_Y patch. Could you try my patch?
It can be obtianed from http://bugs.winehq.org/show_bug.cgi?id=33424#c4 .
As far as my investigation, fabs() in freetype_SelectFont() makes the
font height (lfHeight) to -2147483648 (=0x80000000). SCALE_Y patch
doesn't check ppem value, just left shifts it. So the issue occurs.
I'm currently investing why fabs returns so huge value. But the issue
seems to affect another applications, and conformance tests show that
there is upper bound for lfHeight in Windows. Therefore I implement
upperbounds test in advance.
Regards,
Akihiro Sagawa
More information about the wine-devel
mailing list