[PATCH] mscms: Use lcms2, when available

Hans Leidekker hans at codeweavers.com
Fri May 10 03:32:47 CDT 2013


On Fri, 2013-05-10 at 02:05 +0200, Detlef Riekenberg wrote:
> > For most apps it will be a matter of adding a configure check for lcms2
> > and then recompiling. This is not the case for Wine as you have pointed out.
> - cmsCreateLabProfile was renamed to cmsCreateLab2Profile 
>   cmsvirt.c (1.19: 570) / (2.4: 458 and 497)
> 
> - cmsSetLogErrorHandler can be used as replacement for cmsSetErrorHandler
> 
> > At this point there's probably still a substantial number of users on
> > distributions that don't include lcms2, and trying to support both doesn't
> > make the source any prettier.
> 
> The changes to support both versions are resonable small.

There's more. lcms1 carried the icc34.h header that defines the ICC format.
It's included via lcms.h and we depend on it for functionality that the lcms1
API doesn't provide.

I have some hope that the lcms2 API will be sufficient for this functionality,
otherwise we may have to carry this header ourselves.





More information about the wine-devel mailing list