[PATCH 1/4] ddraw: Restore resolution on EXCLUSIVE->NORMAL switch

Henri Verbeet hverbeet at gmail.com
Wed May 22 05:38:53 CDT 2013


On 22 May 2013 11:20, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> The attached patch passes all the tests without todo_wine. However,
> I'm not sure if there are any unintended side effects when I change
> the order of the swapchain re-creation and focus window
> release/acquire. I'll probably put this into a different patch for
> bisecting reasons.
>
Yeah, makes sense. Applications tend to be pretty sensitive to this
kind of stuff.

> It's merely moved from its original position. I'd like to keep it for
> consistency as pretty much all ddraw methods have a small
> documentation comment.
>
It's not a big deal, but I generally remove those if I touch the
function for some other reason, unless there's information in there
that's not immediately obvious from just looking at the function.



More information about the wine-devel mailing list