[PATCH 1/4] ddraw: Restore resolution on EXCLUSIVE->NORMAL switch

Stefan Dösinger stefandoesinger at gmail.com
Wed May 22 04:20:58 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-05-21 16:04, schrieb Henri Verbeet:
> Well, wined3d_device_restore_fullscreen_window() isn't really
> supposed to generate messages at all, the resize on mode changes
> happens in device_parent_mode_changed().
Things make a lot more sense considering device_parent_mode_changed
and its relation to the focus window message hook.

The attached patch passes all the tests without todo_wine. However,
I'm not sure if there are any unintended side effects when I change
the order of the swapchain re-creation and focus window
release/acquire. I'll probably put this into a different patch for
bisecting reasons.

>> /*****************************************************************************
>>
>> 
+ * IDirectDraw7::RestoreDisplayMode
>> + * + * Restores the display mode to what it was at creation
>> time. Basically. + * + * Returns + *  DD_OK on success + *
>> DDERR_NOEXCLUSIVE mode if the device isn't in fullscreen mode +
>> * +
>> *****************************************************************************/
>
>> 
I don't think that really adds anything.
It's merely moved from its original position. I'd like to keep it for
consistency as pretty much all ddraw methods have a small
documentation comment.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRnI2/AAoJEN0/YqbEcdMwot8QAIlBRbgu6F8ZsWezYm7l6oHD
U9z6MnfHEl9M5jyUmxnIzJPGVvwG2Dd7Kot6+SNwUJs8lK4zM6aCyGmts2q6KK83
Ep3nCsQoGLtWnw1ZfsksW0692jj4wxaOkQMa9FtKR3zIcy82JtB+kNov1yepnOyy
7FMtwgxll4YG6Sfz2fBi6mEQaqTThkvWwEWiezh84SH/M8hWn99MfTwhi6vVT9Cp
A1PgGXm88KJnB1XDe+E2M6Dv8lSyr/59cfyEtCZkv4llfIDscPMINpZKCRsFKORf
b+2liqbXZvAIrsrUXq/nP3BHQdsuf2x0apOGhYwWp4QfqsdT8REY3Zww0V/ggadg
iY17KFejc5e6jBvleF4N5H2JkJUeihhKFqyBJmzHcE/XABEUJa18LIyQdZbbvNNB
YnN29cyps7J0/DMV0BhEmWCnWPPrj4EAHwaD1xbPFGPe7Zp7I12+9dORTisXIvOp
CPho/G/iRHPxqJ9rsgMKzEP0GBewpy6nCwRDzpRw/3M3u9mfmkwR8ekpY6yGZDSz
DIEIcbZ5MkG6fgtfipPAvLmPiBpMs0gB+Ifhxx77T2mIj8STjuq3JQYHhnU0jMwt
CB4pCuiwLrKNTDIZOMqzEJQTDhynmL2Ajmpuh1f2w577uR9N2iHheVVff19a2n5H
8VQ+S33c/3IA7et5U8NO
=WQuN
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ddraw-Restore-resolution-on-EXCLUSIVE-NORMAL-switch.patch
Type: text/x-patch
Size: 16971 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130522/2bd5a93a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ddraw-tests-Add-EXCLUSIVE-NORMAL-coop-level-switchin.patch
Type: text/x-patch
Size: 35777 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130522/2bd5a93a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ddraw-Restore-resolution-on-EXCLUSIVE-NORMAL-switch.patch.sig
Type: application/pgp-signature
Size: 543 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130522/2bd5a93a/attachment-0002.pgp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ddraw-tests-Add-EXCLUSIVE-NORMAL-coop-level-switchin.patch.sig
Type: application/pgp-signature
Size: 543 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130522/2bd5a93a/attachment-0003.pgp>


More information about the wine-devel mailing list