msvcrt: remove hack

Christian Costa titan.costa at gmail.com
Thu May 30 07:20:33 CDT 2013


Le 30/05/2013 13:56, Dmitry Timoshkov a écrit :
> Christian Costa <titan.costa at gmail.com> wrote:
>
>>>>>> and no modern gcc/other compiler that I can find cares.
>>>>> It was probably added because of a tool that warned of the unused
>>>>> parameter ... So it all goes in circles. ;)
>>>>>
>>>>> Ciao, Marcus
>>>>>
>>>>>
>>>>>
>>>> So what about action = NULL instead?
>>> A checker tool should be instructed to ignore that kind of a warning
>>> instead. There are many legitimate cases when a function doesn't use
>>> all of its parameters, in that cases there is no need to take any
>>> special action to silence a warning IMHO.
>>>
>> There is also __attribute__((unused_parameter)) but it's gcc specific.
> How is that better than 'unused = unused'? And it's even more typing...
>
It's a compiler thing like const. It's quite long right. Unless using it 
through a macro like e.g UNUSED.
Normally it is used for handlers whose implementations may not used some 
params.
It may not be the best solution but this can of things exists.



More information about the wine-devel mailing list