gdiplus: Implement GdipCreateRegionRgnData. Take 2.

Dmitry Timoshkov dmitry at baikal.ru
Thu Nov 21 04:05:41 CST 2013


Alexandre Julliard <julliard at winehq.org> wrote:

> Vincent asked you to support more cases, you refused to do that. Then he
> asked you to at least add FIXMEs for the cases you don't want to
> support, and you refused to do that too. I wouldn't call that addressing
> his concerns.

First of all I pointed out that it's most likely impossible to even
encounter the cases of unsupported flags since GdipCreateRegionRgnData
is supposed to handle the data produced by GdipGetRegionData on the same
implementation. Basically any case of a failing GdipCreateRegionRgnData
call should be investigated separately and the reasons may be different
and legitimate. Adding FIXMEs for every GdipCreateRegionRgnData failure
seems not worth the trouble at this point IMO since it's the very first
implementation of the data parser.

Next, my reaction to Vincent's comments was influenced by the fact that
the patch was already rejected under shaky grounds, so arguing about
adding FIXMEs (actually jus one FIXME about path flags) didn't change
the fact that the patch is already rejected, and even adding the proposed
FIXME wouldn't change anything.

-- 
Dmitry.



More information about the wine-devel mailing list