I'm not sure why it was rejected
Marcus Meissner
marcus at jet.franken.de
Wed Oct 2 11:08:16 CDT 2013
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote:
> On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa <matyapiro31 at gmail.com> wrote:
> > I cannnot make sure my patch 99266 was rejected.
>
> I can't really tell why it was rejected but I can tell there are mixed
> space/tabs in the SetLastError lines.
>
> I guess if you SetLastError to not implemented you cannot return S_OK too
>
> Try comparing your patch with other patches that added new dlls. It
> looks like you're missing the changes in configure and Makefile.in.
> http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=commit&s=new+dll
no, he is not as they are autogenerated.
Last open issue was the incorrect licenses.
Ciao, Marcus
More information about the wine-devel
mailing list