[PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

Jactry Zeng jactry92 at gmail.com
Wed Sep 4 12:16:31 CDT 2013

Hi Nikolay,

2013/9/5 Nikolay Sivov <bunglehead at gmail.com>
> On 9/4/2013 07:17, Jactry Zeng wrote:
>> -        ME_EndToUnicode(unicode, wszText);
>> +        ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText);
> It's still ugly to use magic numbers like that, in a similar situation I
had some time
> ago I use ~0 to mark WCHAR data encoding that does need special handling.
> Even with a value like ~0 it needs to be documented in code comments.

Thanks for your review!
But I still can't understand it. :(  Can you show me a commit as an example.

Thank you!

(sorry for forgeting cc wine-devel)
Jactry Zeng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130905/739b28cb/attachment.html>

More information about the wine-devel mailing list