[PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty
wine at stwm.de
Thu Sep 5 04:25:14 CDT 2013
Am Donnerstag, 5. September 2013, 17:52:42 schrieb Dmitry Timoshkov:
> Wolfgang Walter <wine at stwm.de> wrote:
> > On Thursday 05 September 2013 10:42:40 you wrote:
> > > Wolfgang Walter <wine at stwm.de> wrote:
> > > > - ok(!res && GetLastError() == ERROR_IO_PENDING, "%d:
> > > > WaitCommEvent
> > > > error %d\n", i, GetLastError()); + ok(res || (!res &&
> > > > GetLastError() == ERROR_IO_PENDING), "%d: WaitCommEvent error %d\n",
> > > > i,
> > > > GetLastError());
> > >
> > > This change looks spurious and unrelated. Also todos must be removed
> > > in the patch that fixes appropriate behaviour.
> > It is allowed that WaitCommEvent returns immediately with TRUE if there is
> > an event pending, as far as I can see.
> WaitCommEvent always returns FALSE when device is opened in overlapped mode.
Not according to MSN documentation of WaitCommEvent():
"If the overlapped operation cannot be completed immediately, the function
returns FALSE and the GetLastError function returns ERROR_IO_PENDING,
indicating that the operation is executing in the background."
Anstalt des öffentlichen Rechts
More information about the wine-devel