[PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

Dmitry Timoshkov dmitry at baikal.ru
Thu Sep 5 09:32:00 CDT 2013


Wolfgang Walter <wine at stwm.de> wrote:

> > > > > With my patches 1/2 and 2/2 I get:
> > > > > 
> > > > > fixme:iphlpapi:NotifyAddrChange (Handle 0x10ee8e0, overlapped
> > > > > 0x10ee8ec):
> > > > > stub wine: configuration in '/home/walterw/.wine' has been updated.
> > > > > fixme:comm:set_queue_size insize 1024 outsize 1024 unimplemented stub
> > > > > comm.c:857: Test succeeded inside todo block: WaitCommEvent failed
> > > > > with a
> > > > > timeout comm.c:881: Test succeeded inside todo block: WaitCommEvent
> > > > > error
> > > > > 997 comm.c:883: Test succeeded inside todo block: WaitCommEvent:
> > > > > expected
> > > > > EV_TXEMPTY, got 0x4 comm.c:889: Test succeeded inside todo block:
> > > > > WaitCommEvent used 1141 ms for waiting err:comm:set_line_control
> > > > > ByteSize
> > > > > fixme:ntdll:server_ioctl_file Unsupported ioctl 1b000c (device=1b
> > > > > access=0
> > > > > func=3 method=0) comm.c:2036: Tests skipped: interactive tests (set
> > > > > WINETEST_INTERACTIVE=1)
> > > > 
> > > > Successes inside of todo_wine blocks are treated as failres.
> > > 
> > > So you think I should remove the wine_todos already here?
> > 
> > No, the source of the failures is still there.
> 
> What do you mean with that? The tests indeed do succeed now and there is a 
> reason they do: when you call WaitCommEvent() while the tx buffer is not empty 
> yet the wine code will detect that EV_TXEMPTY correctly:

The tests must pass under Wine without any additional "fixes" as they do
currently under Windows. If you add some code to the tests which suddenly
makes them pass under Wine - that's not a fix, Wine implementation should
be fixed instead.

-- 
Dmitry.



More information about the wine-devel mailing list