[PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty
dmitry at baikal.ru
Thu Sep 5 10:07:27 CDT 2013
Wolfgang Walter <wine at stwm.de> wrote:
> > > > No, the source of the failures is still there.
> > >
> > > What do you mean with that? The tests indeed do succeed now and there is a
> > > reason they do: when you call WaitCommEvent() while the tx buffer is not
> > > empty
> > > yet the wine code will detect that EV_TXEMPTY correctly:
> > The tests must pass under Wine without any additional "fixes" as they do
> > currently under Windows. If you add some code to the tests which suddenly
> > makes them pass under Wine - that's not a fix, Wine implementation should
> > be fixed instead.
> You basically say that one may not fix a bug before fixing another one which
> is not related only because they are tested for in a special order and these
> tests influence each other though they are not really related.
Adding a workaround to the tests to compensate a Wine bug and as a side effect
remove some todo_wines is not a fix. Yes, some tests depend on each other, but
that's on purpose, there is no need to break this dependency just because you
can make some later tests suddenly "pass".
More information about the wine-devel