[PATCH 4/5] wined3d: Move the decoded stream info into the context

Stefan Dösinger stefan at codeweavers.com
Mon Sep 9 06:49:13 CDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-09-09 13:42, schrieb Henri Verbeet:
> I think that's an unfortunate place to insert the field, and you 
> should update the padding.
> 
>>> @@ -1880,9 +1889,7 @@ struct wined3d_device WORD 
>>> d3d_initialized : 1; WORD inScene : 1;                   /* A 
>>> flag to check for proper BeginScene / EndScene call pairs */ 
>>> WORD softwareVertexProcessing : 1;  /* process vertex shaders 
>>> using software or hardware */ -    WORD useDrawStridedSlow : 1;
>>> WORD filter_messages : 1; -    WORD padding : 8;
> Padding?
Do we need it? The compiler should take care of it for this structure
- - unlike texture_stage_op, where we don't memset the structure to zero
and explicitly set the padding to 0.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSLbW5AAoJEN0/YqbEcdMwRDAP/0coCS3OKzCZw/qcjZ8GbKCY
J2imUtGc6aOhlWPgpzPrIs1yy4JWGosrobYjRKaYpfN7IuxsUgZ011vo0gCSyC0q
YRNIo3ExRgR5gSal4l9v4o6UvPgvWhTiSa/ay9Gwqwy/1FXWhI9wEne0miJ75JLg
5BhVl54kaa2dKOAZac9xD3hL+3lKZadsvKO78VUGenGUYo78IQp7tRlAA2IRwKrS
AfywhobK3v0yA2eA4xMMV7gbjx3lcLBSxG7z4+JvkWlaSTUG13ndSldyDwZ4kCwl
LuD/MaZZem8oVBiYnWLuGbXJ3hfvIcmJTiGKzPFbirE7eZMA3g7wgBJhUGPK5Urx
kRA0zbF6FNq0GfoXg/FVbKL2mcaahzIpm3qOHGkv/U5sv4g+6SSEoGyi69Kyjq6o
ixqOCmuY5Yj+AHTzcorFpcDxWQX0eqOZnlkhwI0yCyiIQm0rNVOcZ5DmzwjVKnfb
jRLcs7TwazoEjVfhfzSMRez+r6cngxsXsQMmbnvp9O4BZactJnYT62OmfRCvJ5Zu
RXrppcDhpIr/adw7j1p7htDqCzWgUVLhKvxQUaNBUeBhRnNCdJjSMlVcCiNGOvkl
VCrFUYYQh0bMpVmhx4BsnjgkcKixxYHsWBSf8VKUOLL7jKwXzg/gjSIC1wPZrKUb
R4MgltrET/xMpgL7j8CB
=KW1K
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list