(resend) [PATCH] serial: wait_for_event() must set Information in PIO_STATUS_BLOCK

Dmitry Timoshkov dmitry at baikal.ru
Wed Sep 11 01:02:12 CDT 2013


Wolfgang Walter <wine at stwm.de> wrote:

> -    if (commio->iosb) commio->iosb->u.Status = *commio->events ? STATUS_SUCCESS : STATUS_CANCELLED;
> +    if (commio->iosb) {
> +        commio->iosb->u.Status = *commio->events ? STATUS_SUCCESS : STATUS_CANCELLED;
> +        if (*commio->events)
> +            commio->iosb->Information = sizeof(DWORD);
> +    }

Did you run 'make test' with this change? Probably some todo_wine
statements need to be removed.

Also why 'Information' is set only in the case if events != 0?
I'd guess that it should be set in any case since 'events' is
always initialized.

-- 
Dmitry.



More information about the wine-devel mailing list