[PATCH 2/8] wined3d: Introduce a format flag for volume texture support.

Henri Verbeet hverbeet at gmail.com
Tue Sep 17 06:55:08 CDT 2013

On 17 September 2013 11:39, Stefan Dösinger <stefan at codeweavers.com> wrote:
> diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h
> index 4928f92..eabf890 100644
> --- a/dlls/wined3d/wined3d_private.h
> +++ b/dlls/wined3d/wined3d_private.h
> @@ -2927,6 +2927,7 @@ extern enum wined3d_format_id pixelformat_for_depth(DWORD depth) DECLSPEC_HIDDEN
>  #define WINED3DFMT_FLAG_HEIGHT_SCALE                0x00040000
>  #define WINED3DFMT_FLAG_TEXTURE                     0x00080000
>  #define WINED3DFMT_FLAG_BLOCKS_NO_VERIFY            0x00100000
> +#define WINED3DFMT_FLAG_VOLUME                      0x00200000
I don't like this approach much. I think we should either do the right
thing right away and have separate flags for each GL resource type
(i.e., vertex/index buffers, renderbuffers, 1D/2D/3D/CUBE/RECT
textures), or just keep assuming they're the always the same and
handle the exceptions for volumes like a quirk flag like
WINED3DFMT_FLAG_BROKEN_PITCH. In either case this should probably have
corresponding support for ARB_internalformat_query2 as well, and I'd
prefer "TEXTURE3D" over "VOLUME".

More information about the wine-devel mailing list