winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

Roderick Colenbrander thunderbird2k at gmail.com
Fri Sep 20 09:44:00 CDT 2013


That change looks suspicious. If switching to i+1 fixes a problem, the real
problem is that the if-statement in question gets entered in the first
place. Some bounds checking on the outer for-loop (the one which loops
through nCfgs and nMaxFormats), is probably wrong then. I had issues with
this part in the past, so there maybe a small typo (it may just be off by
1).

Roderick


On Thu, Sep 19, 2013 at 6:37 PM, Ken Thomases <ken at codeweavers.com> wrote:

> ---
> dlls/winex11.drv/opengl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20130920/41cf2244/attachment.html>


More information about the wine-devel mailing list