[PATCH 2/2] ddraw: Return empty D3D hardware flags for HEL device enumeration.
Henri Verbeet
hverbeet at gmail.com
Mon Aug 4 08:58:54 CDT 2014
On 31 July 2014 00:57, Erich E. Hoover <erich.e.hoover at gmail.com> wrote:
> @@ -537,12 +537,16 @@ static HRESULT WINAPI enumDevicesCallback(GUID *Guid, char *DeviceDescription,
>
> ok(hal->dcmColorModel == 0, "RGB Device %u hal caps has colormodel %u\n", ver, hal->dcmColorModel);
> ok(hel->dcmColorModel == D3DCOLOR_RGB, "RGB Device %u hel caps has colormodel %u\n", ver, hel->dcmColorModel);
> +
> + ok(hal->dwFlags == 0, "RGB Device %u has hardware flags %x\n", ver, hal->dwFlags);
> }
> else if(IsEqualGUID(&IID_IDirect3DHALDevice, Guid))
> {
> trace("HAL Device %d\n", ver);
> ok(hal->dcmColorModel == D3DCOLOR_RGB, "HAL Device %u hal caps has colormodel %u\n", ver, hel->dcmColorModel);
> ok(hel->dcmColorModel == 0, "HAL Device %u hel caps has colormodel %u\n", ver, hel->dcmColorModel);
> +
> + ok(hal->dwFlags != 0, "HAL Device %u has hardware flags %x\n", ver, hal->dwFlags);
> }
In principle this patch looks plausible enough. What about
hel->dwFlags though, and what about other device types like Ref, MMX,
etc.?
More information about the wine-devel
mailing list