ddraw/tests: Correct test condition (PVS-Studio)
Michael Stefaniuc
mstefani at redhat.com
Mon Aug 18 02:43:23 CDT 2014
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/17/2014 10:01 AM, Nikolay Sivov wrote:
>> rc = IDirectDrawSurface_GetSurfaceDesc(lpDst, &ddsd3); ok(rc ==
>> DD_OK, "IDirectDrawSurface_GetSurfaceDesc between a lock/unlock
>> pair returned %08x\n", rc); - ok(ddsd3.lpSurface ==
>> ddsd3.lpSurface, "lpSurface from GetSurfaceDesc(%p) differs from
>> the one returned by Lock(%p)\n", ddsd3.lpSurface,
>> ddsd2.lpSurface); + ok(ddsd3.lpSurface == ddsd2.lpSurface,
>> "lpSurface from GetSurfaceDesc(%p) differs from the one returned
>> by Lock(%p)\n", ddsd3.lpSurface, ddsd2.lpSurface);
>
>
> So I guess it means test is incorrect, and implementation too.
Correct. One of my scripts has detected the comparison to self.
I pinged Stefan and he wanted to look at it but seems that it got
forgotten. There might be even emails on wine-devel about this >1 year
ago.
bye
michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iD8DBQFT8a6b0ei8kcpE1VERAoXgAJ9mV2gofvoSGwVqkRm0Om++dzMg4ACghDA0
gwkDBGFfhhrn3zWbIDjGFSU=
=NdDR
-----END PGP SIGNATURE-----
More information about the wine-devel
mailing list