msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)

YongHao Hu christopherwuy at gmail.com
Fri Aug 15 04:49:41 CDT 2014


Thank you for your comment.

+        if(r%2 & 1)

How do you think of this if condition now?

On Thursday, August 14, 2014 09:45 PM, Piotr Caban wrote:
> On 08/10/14 10:32, YongHao Hu wrote:
>> +complex_float* __cdecl complex_float_pow_ci(complex_float *ret, 
>> const complex_float *l, int r)
>> +{
>> +    complex_float c = *l;
>> +    complex_float temp = { 1.0, 0 };
>> +    complex_float_assign(ret, &temp);
>> +
>> +    if(r < 0){
>> +        r = -r;
>> +        complex_float_div(&c, &temp, l);
>> +    }
>> +
>> +    for(; r>0; r>>=1)
>> +    {
>> +        if( (r%2)&1 )
> Please fix the if condition. You're also using tabs in the patch, 
> please use spaces instead.
>
> Thanks,
> Piotr




More information about the wine-devel mailing list