[PATCH] dsound: do not allow adding a NULL ptr as buffer in DirectSoundDevice_AddBuffer()

[Pierre Schweitzer]

Not sure about how to handle that one.
It's an internal method AFAIK.

On 24/12/2014 15:20, Nikolay Sivov wrote:
> On 12/24/2014 04:55 PM, Pierre Schweitzer wrote:
>> Dear all,
>>
>> Please find attach a patch which prevents DirectSoundDevice_AddBuffer()
>> from accepting NULL pointers.
>> It results from a bugfix & testing here. While trying to start Steam
>> Lego Star Wars, I was experiencing an invalid address dereference in
>> DSOUND_ChangeListener() (line 312).
>>
>> Adding this check makes the game work properly (with sound). I tested it.
>>
>> Cheers,
>>
> 
> Please add a test for that.
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3940 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20141224/4e185985/attachment.bin>