ntdll: fix read_directory_getdirentries() under FreeBSD.

Mon Dec 29 07:32:20 CST 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 28.12.2014 um 21:09 schrieb David Naylor:
> 
> Change the handling of getdirentries(2) by: - tracking the data pointer instead of subtracting 'res' - simplify rewind by skipping re-appending entries onto the list - try make the logic easier to follow --- dlls/ntdll/directory.c | 73 +++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 45 deletions(-)

Hi and welcome to Wine development,
maybe it's just me, but the patch is not easy to review.
Is it possible to split the patch into multiple atomic patches (maybe three, as in the change list you provided)?
Also, how does the patch fix Wine on FreeBSD?
A quick look at the patch itself:
You missed a whitespace at the last lseek call.
You're adding a FIXME comment, but you should rather clarify your question, use wine-devel and/or IRC and/or "git blame" for that.