ddraw/tests: Skip the primary palette tests if the 640x480x8 mode is not supported.

[Francois Gouget]

On Wed, 12 Feb 2014, Henri Verbeet wrote:

> On 12 February 2014 10:28, Francois Gouget <fgouget at codeweavers.com> wrote:
> >      hr = IDirectDraw_SetDisplayMode(ddraw, 640, 480, 8);
> > +    if (hr == E_NOTIMPL)
> > +    {
> > +        win_skip("8bpp display mode is not supported\n");
> > +        DestroyWindow(window);
> > +        return;
> > +    }
> Is this for the Win 8 testbot? Unsupported display modes should return
> DDERR_UNSUPPORTED, and 640x480 at 8 bpp should pretty much always be
> supported. Does changing display modes work at all on that VM? IIRC it
> had more issues with changing display modes, and not just in the ddraw
> tests.

My Windows 8.1 laptop (Intel HD4000) also returns E_NOTIMPL for these 
tests (among other errors). Fixing this crash does reveal other errors.

ddraw:ddraw1 start dlls/ddraw/tests/ddraw1.c -
ddraw1.c:1329: Test failed: Expected color 0x000000ff for test 0, got 0x00ff0000.
ddraw1.c:1329: Test failed: Expected color 0x000000ff for test 1, got 0x00ff0000.
ddraw1.c:3949: Test failed: Got unexpected color 0x000000ff.
ddraw1.c:3982: Test failed: Got unexpected color 0x000000ff.
ddraw1.c:3995: Test failed: Got unexpected color 0x00ff0000.
ddraw1.c:4081: Test failed: Failed to set display mode, hr 0x80004001.
ddraw1.c:4106: Test failed: Failed to set palette, hr 0x88760091.
ddraw1.c:4108: Test failed: Got unexpected refcount 1.
ddraw1.c:4112: Test failed: Got unexpected palette caps 0x44.
ddraw1.c:4116: Test failed: Failed to set palette, hr 0x8876023c.
ddraw1.c:4125: Test failed: Failed to set palette, hr 0x88760091.
ddraw1.c:4127: Test failed: Got unexpected refcount 1.
ddraw1.c:4130: Test failed: Failed to get palette, hr 0x8876023c.
ddraw1.c:4131: Test failed: Got unexpected palette 00000000, expected 006542E8.
ddraw1.c:4131: this is the last test seen before the exception
ddraw1: unhandled exception c0000005 at 00410079
ddraw:ddraw1 done (-1073741819) in 29s

ddraw:ddraw2 start dlls/ddraw/tests/ddraw2.c -
ddraw2.c:1583: Test failed: Expected color 0x000000ff for test 0, got 0x00ff0000.
ddraw2.c:1583: Test failed: Expected color 0x000000ff for test 1, got 0x00ff0000.
ddraw2.c:4630: Test failed: Got unexpected color 0x000000ff.
ddraw2.c:4663: Test failed: Got unexpected color 0x000000ff.
ddraw2.c:4676: Test failed: Got unexpected color 0x00ff0000.
ddraw2.c:5178: Test failed: Failed to set display mode, hr 0x80004001.
ddraw2.c:5203: Test failed: Failed to set palette, hr 0x88760091.
ddraw2.c:5205: Test failed: Got unexpected refcount 1.
ddraw2.c:5209: Test failed: Got unexpected palette caps 0x44.
ddraw2.c:5213: Test failed: Failed to set palette, hr 0x8876023c.
ddraw2.c:5222: Test failed: Failed to set palette, hr 0x88760091.
ddraw2.c:5224: Test failed: Got unexpected refcount 1.
ddraw2.c:5227: Test failed: Failed to get palette, hr 0x8876023c.
ddraw2.c:5228: Test failed: Got unexpected palette 00000000, expected 0092BF68.
ddraw2.c:5228: this is the last test seen before the exception
ddraw2: unhandled exception c0000005 at 0041EA0D
ddraw:ddraw2 done (-1073741819) in 35s

ddraw:ddraw4 start dlls/ddraw/tests/ddraw4.c -
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 400,60, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 560,60, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 400,180, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 560,180, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 80,300, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 240,300, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 400,300, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 560,300, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 80,420, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 240,420, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 400,420, got 0x00ff0000.
ddraw4.c:1216: Test failed: Expected color 0x0000ff00 at 560,420, got 0x00ff0000.
ddraw4.c:1721: Test failed: Expected color 0x000000ff for test 0, got 0x00ff0000.
ddraw4.c:1721: Test failed: Expected color 0x000000ff for test 1, got 0x00ff0000.
ddraw4.c:5233: Test failed: Got unexpected color 0x000000ff.
ddraw4.c:5266: Test failed: Got unexpected color 0x000000ff.
ddraw4.c:5279: Test failed: Got unexpected color 0x00ff0000.
ddraw4.c:5774: Test failed: Failed to set display mode, hr 0x80004001.
ddraw4.c:5799: Test failed: Failed to set palette, hr 0x88760091.
ddraw4.c:5801: Test failed: Got unexpected refcount 1.
ddraw4.c:5805: Test failed: Got unexpected palette caps 0x44.
ddraw4.c:5809: Test failed: Failed to set palette, hr 0x8876023c.
ddraw4.c:5818: Test failed: Failed to set palette, hr 0x88760091.
ddraw4.c:5820: Test failed: Got unexpected refcount 1.
ddraw4.c:5823: Test failed: Failed to get palette, hr 0x8876023c.
ddraw4.c:5824: Test failed: Got unexpected palette 00000000, expected 008ED930.
ddraw4.c:5824: this is the last test seen before the exception
ddraw4: unhandled exception c0000005 at 00445764
ddraw:ddraw4 done (-1073741819) in 34s


-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
              Linux: Because rebooting is for adding new hardware