Patch to fix bug 34324

Zhenbo Li litimetal at gmail.com
Fri Feb 21 21:19:41 CST 2014


2014-02-19 17:47 GMT+08:00 Zhenbo Li <litimetal at gmail.com>:
> Hello,
> I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324.
> Till now, I have found two solutions, one is simple and one is
> complex. Both of them would fix #34324, and I don't know which one is
> better.
>
> As Alexandre Julliard mentioned[1], I would use the value of
> GetLastError() as the return (error) value in delete_files().
>
> The simple patch would fix part of the 'todo_wine' marks.
> Meanwhile, the complex patch would fix *all* todo marks about return
> value in test_delete().
>
> I really appreciate your help (especially for Dmitry Timoshkov, thank
> you very much). And I'm looking for your feedbacks.
>
> Thank you.
>
> [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchhmsfz+state:results


Sorry to bother you.
I don't know which patch is preferred, could someone give me any suggestions?

Also, I'm sorry for the format problems. I'll re-check them before sending them
to wine-patches.

Any suggestions are greatly appreciated.
Thank you.


-- 
Have a nice day!
Zhenbo Li



More information about the wine-devel mailing list