[PATCH] bcrypt: Added stub implementation for BCryptGetFipsAlgorithmMode

Kai Blaschke kai.blaschke at kb-dev.net
Thu Jan 23 02:40:55 CST 2014


Dmitry Timoshkov <dmitry at baikal.ru> wrote:

> user32 and gdi32 APIs are not used in the test and should be removed
> from the imports list.
>
> Probably BCryptGetFipsAlgorithmMode should be loaded dynamically.
> A usual test for invalid (NULL) argument would be useful. Also
> status should be printed in hex to match ntstatus.h definitions.

Valid points, consider it done.
Additionally, I did some quick research about the implementation of 
BCryptGetFipsAlgorithmMode, and all it actually does is querying two 
registry keys, as documented in the Windows knowledge base article 
811833 (http://support.microsoft.com/kb/811833/en-us). I'm going to 
implement this properly instead of a stub, and also add a NULL pointer 
check for pfEnabled, returning STATUS_INVALID_PARAMETER if it fails. 
Scrub my patch, I'll send in a new one.

--
Kai



More information about the wine-devel mailing list