shell32/tests: Add test for GetLastError in shlfileop

Dmitry Timoshkov dmitry at
Mon Jan 27 23:43:24 CST 2014

Zhenbo Li <litimetal at> wrote:

> There are many 'todo_wine' marks in shell32 test, and it really caused
> bugs(like 34324).

According to the comments and the attached hack in the bug 34324 the problem
there is not related to the last error set but to the returned error value,
so you probably should add the tests for that particular behaviour.

> Maybe such test cases can contribute to further development?

Adding the tests is good in general, but the tests should be added very
carefully, and check something that real applications could depend upon.
Adding blanket tests just for everything is a waste of time IMHO.


More information about the wine-devel mailing list