wininet: InternetGetConnectedStateExW must return TRUE for success

Bruno Jesus 00cpxxx at gmail.com
Wed Jan 29 05:02:44 CST 2014


On Wed, Jan 29, 2014 at 7:48 AM, Michael Stefaniuc <mstefani at redhat.com> wrote:
>> -    return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen);
>> +    return LoadStringW(WININET_hModule, IDS_LANCONNECTION, lpszConnectionName, dwNameLen) ? TRUE : FALSE;
> we're getting rid of "? TRUE : FALSE" constructs in Wine as those are
> ugly and confusing.

Oops, sorry.

> In this case a "return LoadStringW() != 0;" or even "> 0" is better as
> LoadString returns 0 on failure and a string length on success.

Thank you, I'll resend when I get home.

> bye
>         michael

Best wishes,
Bruno



More information about the wine-devel mailing list