[PATCH 2/4] vbscript: Implemented Sgn(try 5)

[Shuai Meng]

Thank you for commenting.


2014-07-03 1:31 GMT+08:00 Piotr Caban <piotr.caban at gmail.com>:

> Hi,
>
>
> +Sub testSgnError(strings, error_num)
> +    on error resume next
> +
> +    Call Err.clear()
> +    Call Sgn(strings)
> +    Call ok(Err.number = error_num, "Err.number = " & Err.number)
> +End Sub
> +
> +Call testSgnError(Null, 445)
> This test fails on windows. Tests needs to pass both on windows and on
> wine.
>
> Yeah, it should fail. Sgn(Null) always returns error number 94 on windows.
If we want Sgn(Null) to return the same error number on wine, we should use
the right error const which is defined in  include/winerror.h when
V_VT(arg) == VT_NULL. That means,  E_NOTIMPL is not the best one, we should
find a replacement.

Problem is, though I have tried every const from
DISP_E_UNKNOWNINTERFACEto DISP_E_UNKNOWNINTERFACE,
none of them is right. I have no idea what to do now.

+    if(V_VT(arg) == VT_NULL) {
> +        FIXME("Null argument not supported\n");
> +            return E_NOTIMPL;
> +    }
> Please fix the indentation here.
>
> Cheers,
> Piotr
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20140703/4c26075e/attachment.html>