[1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback.

Henri Verbeet hverbeet at gmail.com
Mon Jul 7 06:16:16 CDT 2014


On 4 July 2014 00:40, Andrei Slăvoiu <andrei.slavoiu at gmail.com> wrote:
> +        /*Direct 3D 9 SM3*/
This is pretty minor, but could you please make that "/* Direct3D 9
SM3 */", etc.?

> +        {"HD 6770M",CARD_AMD_RADEON_HD6600M},
> +        {"HD 6750M",CARD_AMD_RADEON_HD6600M},
Since you're touching the entire table anyway, please add some extra
space here, preferably enough to make the "Radeon Xpress" entry from
the next patch fit as well.

> +····
> +    /* Radeon R5xx */
Trailing whitespace.

You missed select_card_nvidia_mesa():
directx.c:2270:5: warning: initialization from incompatible pointer
type [enabled by default]
directx.c:2270:5: warning: (near initialization for
‘nvidia_gl_vendor_table[1].select_card’) [enabled by default]



More information about the wine-devel mailing list