[PATCH 3/4] vbscript: Implemented Abs(try 7)

[Shuai Meng]

2014-07-13 22:35 GMT+08:00 Piotr Caban <piotr.caban at gmail.com>:

> On 07/13/14 15:49, Shuai Meng wrote:
>
>>     You're not handling res==NULL case correctly. E.g. Call
>>     Abs("string") should fail.
>>
>> I have tested this case for many times, and I think  Call Abs("string")
>> is just OK https://testbot.winehq.org/JobDetails.pl?Key=7967
>> and it's OK that write directly using vbscript on wiinxp and win7.
>>
> Abs should behave in the same way no matter it's return value is used or
> not. You have added following test:
> Call Abs(-4)
> it succeeds because -4 is a valid Abs argument. If you add this test:
> Call Abs("string")
> it will fail on windows.
>
> OK，I misunderstand you at first. So maybe I can just remove the two lines
when res == NULL, I tested it and the result is good.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20140714/507a79a8/attachment.html>