[1/9] wined3d: Make the card selection for binary drivers depend only on gl_renderer like it already is for the mesa drivers and remove the gl_info parameter from the select_card callback. (try2)

Andrei Slăvoiu andrei.slavoiu at gmail.com
Tue Jul 15 13:54:24 CDT 2014


În ziua de Mar 15 Iul 2014, la 12:52:25, Henri Verbeet a scris:
> I'd probably let the cards that currently aren't matched against a
> specific renderer string just hit the fallback code, since that's
> effectively what was happening before.
So remove the matchers that I added (GeForce3 and Geforce) and leave the 
existing ones. BTW, GeForce2 was a already there, but because of the OpenGL 
level check it was not matched for newer cards. Now it might cause problems if 
Nvidia decides to use GeForce2000 for a future card.

> For what it's worth, you may also want to consider splitting this by
> e.g. first getting rid of d3d_level_from_gl_info() in
> select_card_nvidia_binary(), then in select_card_amd_binary(), etc.,
> and try to avoid large series. I.e., first work on getting the first 5
> or so patches comitted, then work on the next couple, etc.
So drop this series completely and start over with smaller ones?



More information about the wine-devel mailing list