[1/3] oleaut32: Add test for TLB dependencies lookup in resources (try 2)

Alexandre Julliard julliard at winehq.org
Fri Jul 25 02:30:47 CDT 2014


Guillaume Charifi <guillaume.charifi at sfr.fr> writes:

> Alexandre Julliard <julliard at winehq.org> writes: > It doesn't work
> here: > > ../../../tools/runtest -q -P wine -T ../../.. -M
> oleaut32.dll -p oleaut32_test.exe.so typelib && touch typelib.ok >
> typelib.c:5528: Test failed: test_tlb.tlb is on the path or registered
>> typelib.c:5542: Test succeeded inside todo block: got: 0 > make[1]:
> *** [typelib.ok] Error 2
>
> Yes, in fact the test does not make sense if the test_tlb.tlb is locatable on disk by the program, it must be out of the path.
> That's why I was initially just skipping the test if test_tlb.tlb could be loaded from disk, but some suggested me to make the
> test fail in that case.
> Should I restore the old behaviour ? Or do something else ?

If the goal of the test is to see what happens when it can't be found in
the path, you need to make sure that it can never be found. If you skip
in that case you are not testing anything.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list