ws2_32/socket.c: Fix compile for linux systems without net/ipx.h

Felix Janda felix.janda at posteo.de
Fri Jun 13 13:46:00 CDT 2014


Bruno Jesus wrote:
> On Fri, Jun 13, 2014 at 2:14 PM, Felix Janda <felix.janda at posteo.de> wrote:
> > ...
> > Not defining HAS_IPX would also fix the compilation but I don't see
> > why one has to disable IPX because of 2 ipx specific constants not
> > declared in linux/ipx.h. (The 2 constants are also declared in an
> > kernel header not exported to userspace.)
> >
> > I'm not sure what's the best solution. I guess that one of the main
> > remaining uses of IPX in linux is to play old network games in wine.
> > Other possible solutions are for musl to include a netipx/ipx.h
> > header (unlikely, the headers are tried to be kept as clean as
> > possible) or declare the constants in sys/socket.h (maybe) or for
> > the kernel to include the constants in linux/ipx.h.
> 
> If the system does not #define the required variables to support IPX
> then I don't think it's right to manually define then and assume they
> will work. I'll download it and give it a try later.

The constants are only used for the [sg]etsockopt() system calls.
They are hardcoded in the linux kernel.

As stated above I'm open to alternative solutions than the patch.

Thanks for trying to reproduce the problem.

Felix



More information about the wine-devel mailing list