[PATCH 3/4] vbscript: Implemented Sgn(try 3)

[Piotr Caban]

On 06/25/14 11:35, Piotr Caban wrote:
> On 06/25/14 04:21, Shuai Meng wrote:
>> +    hres = VariantChangeType(&dst, v, VARIANT_LOCALBOOL, VT_R8);
> There's no need to pass VARIANT_LOCALBOOL flag here.
>
>>   static HRESULT Global_Sgn(vbdisp_t *This, VARIANT *arg, unsigned
>> args_cnt, VARIANT *res)
>>   {
>> -    FIXME("\n");
>> -    return E_NOTIMPL;
>> +    double v;
>> +    HRESULT hres;
>> +
>> +    TRACE("(%s)\n", debugstr_variant(arg));
>> +
>> +    assert(args_cnt == 1);
>> +
>> +    hres = to_double(arg, &v);
>> +    if (FAILED(hres))
>> +        return S_OK;
I haven't seen it earlier, you should probably return hres here.