[PATCH] vbscript: Fixed CBool(try 2)

Piotr Caban piotr.caban at gmail.com
Thu May 1 04:59:12 CDT 2014


On 05/01/14 10:16, Shuai Meng wrote:
> Changelog:
>    added tests on object subtype.
>    improved CBool.
>
> https://newtestbot.winehq.org/JobDetails.pl?Key=6689
>
> ---
>   dlls/vbscript/global.c      | 41
> ++++++++++++-----------------------------
>   dlls/vbscript/tests/api.vbs | 42
> ++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 54 insertions(+), 29 deletions(-)
The tests are not passing on wine:
run.c:1013: Test failed: api.vbs: L"Err.number = 0"
run.c:1013: Test failed: api.vbs: L"Err.number = 0"
run.c:1013: Test failed: api.vbs: L"Err.number = 0"

These are the failing tests:
Call testCBoolError("#TRUE#", 458)
Call testCBoolError("#FALSE#", 458)
Call testCBoolError(MyObject, 458)

Could you please also add following tests:
MyObject.myval = 1
Call ok(CBool(MyObject) = True, "CBool(MyObject) = " & CBool(MyObject))
MyObject.myval = 0
Call ok(CBool(MyObject) = False, "CBool(MyObject) = " & CBool(MyObject))



More information about the wine-devel mailing list