wininet: Fix InternetGetConnectedStateEx[A|W] (try 2, resend)

Alexandre Julliard julliard at winehq.org
Fri May 9 09:53:57 CDT 2014


Bruno Jesus <00cpxxx at gmail.com> writes:

> Hi, thanks for the review =)
> I'm not at home so I can't check it more carefully but judging by the
> patch I think this is the test:
>
> +    buffer[0] = 0xDE;
> +    res = pInternetGetConnectedStateExA(&flags, buffer, 1, 0);
>      ok(res == TRUE, "Expected TRUE, got %d\n", res);
>      ok(flags, "Expected at least one flag set\n");
>      ok(strlen(buffer) == 0, "Expected 0 bytes, got %u\n", lstrlenA(buffer));
>
> It sets some content inside the buffer and then ensures the string is
> zero sized after returning. As far as I remember if you comment the
> line "*lpszConnectionName = '\0'" one or more tests will result in
> error. I can do a more careful research at the weekend if you wish.

It would need to use a size larger than 1 to confirm that the string is
supposed to be cleared instead of simply truncated.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list