Fix for PlgBlt, the XFORM matrix was calculated incorrectly

[Bruno Jesus]

On Tue, May 20, 2014 at 1:39 PM, Alexander Almaleh <sashoalm at gmail.com> wrote:
> I had tried to submit a patch for that 5 years ago, but couldn't figure out
> how to make a patch/test it, and eventually gave up and forgot about it. But
> recently I remembered about it, and now I want to try again.
>
> So, this time I've prepared a test that can prove that the previous
> implementation does not calculate the XFORM matrix correctly, and that my
> patch will fix it.
>
> The test is a VC6 project, you can find it at
> https://drive.google.com/file/d/0B9PGUhmmnsm1S2VvZzc3WmhBY3c/edit?usp=sharing.
> The test is a demo of PlgBlt that I found on CodeProject. You can compare
> how it works on XP and on Wine. For testing, I directly inserted the
> original Wine implementation of PlgBlt, as well as my patched version, into
> the VC6 project, and tested on that. This is because there seems to be an
> additional problem with MaskBlt, which I'll try tackling next.
>

I can confirm your code works in XP. I think the first thing to do is
to create a bug to take care of the issue.