[PATCH 7/7] reg: Clean up reg_delete

Tue Nov 4 17:08:28 CST 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-11-04 21:15, schrieb Jonathan Vollebregt:

> +#define MAX_VALUE_NAME  16384
This is ugly. Why not use lpcMaxValueNameLen from RegQueryInfoKey like
the old code does?

> +#define ERROR_NO_DELETE_ROOTKEY 20003
Ah, here we have the case I raised in patch 3 :-) . This seems like
another error case that advapi32 should be able to handle for you. It
needs tests in reg.exe and advapi32.dll. That's assuming the call is
really supposed to fail - if it succeeds we obviously don't want to
test it and destroy the Windows installation in the process.

Before you test this on the testbot ask fgouget if it is safe to test.
I believe it is since the VMs are restored from read-only snapshots
after every test run.