[PATCH 3/7] reg: Add path/key conversion functions

[Jonathan Vollebregt]

On 11/06/2014 03:54 PM, Stefan Dösinger wrote:
>> Reg is supposed to throw an error if the key ends in more than one
>> backslash, RegCreateKey/RegOpenKey doesn't so it has to be checked
>> manually.
> Do we have tests for the RegCreateKey / RegOpenKey behavior? I did not
> find any when I looked.

I ran a quick one on testbot myself that confirmed it, but didn't write 
up a proper one.

>> The message with ERROR_INVALID_DATATYPE says it indicates the
>> *data* has the wrong type, nothing about the type itself.
> Huh, I am not sure I understand what this means or what the difference
> is :-\ .

Huh. After looking up the error message I can't find it. Perhaps I was 
looking at a different error. Yeah ERROR_INVALID_DATATYPE looks good, 
I'll use that one.

Speaking of - since the type_get_wchar and wchar_get_type functions 
return 2 states like path_get_rootkey, should I have them return 
pointers too? (Or DWORD -1 for error in the case of wchar_get_type)

>> Given an incorrect type RegSetValueEx returns ERROR_ACCESS_DENIED,
>> which isn't the most descriptive of error codes. Perhaps it would
>> still be better to make our own more descriptive error code
> Agreed, ERROR_ACCESS_DENIED is a bit unfortunate. This is the behavior
> of Windows, not Wine's implementation, right?

Yeah, both windows and wine return ERROR_ACCESS_DENIED