[PATCH 1/5] d3d9: Refuse to reset a lost device.

Stefan Dösinger stefandoesinger at gmail.com
Sun Nov 30 11:28:31 CST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-11-28 16:08, schrieb Henri Verbeet:
> Do you need the InterlockedCompareExchange()?
Tbh I'm not sure when it is needed and when it isn't, so I chose to go
for the safe option. I know the read of device->device_state should be
atomic if its address is 4 byte aligned (and if it isn't
InterlockedCompareExchange won't help). But on the other hand you've
used it for read-only access in the fence implementation in your
command stream work. What was the reason for that? Preventing the loop
from looping over an unchanged register?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUe1O+AAoJEN0/YqbEcdMwfDkP/3c4tHlBu0G+RpZoViU9b1la
gVBVko0zmaMjjSwdq+KO2JuRK8BXh3AFSk72sH8SDLeJBiUPM1ielzZiLkgduevW
SoQrxM2ELOnLuFfbQRceytCauZcLOWd4FbmRHyAR5HklIrz+9FBmdATdo91K4n/K
xzy36/X8uXjIGgqwWg0o/+hSMmS+Fav+X1FnjFwF+ZU/7iq7ORop+6MYUaK5w3Ku
ukOy8nfuyTRMSdqX0FkGp1R2rvQgQTI3nWfeiqlDRVS9Zl3704uTNYbO/Hs6mlRw
AxY1Hfi5rpD8+CfCRr04W7oDvGu34CQeODdEdT9n2UckJQMWxxJCnT4SYqarNBna
4ZUcqdIyxtJP6+2Q2VJYfXMFXYkkkzsdtCeZiARmBUXIzaQFahz+pmAWyec8HyMS
5wIvrhgTx77WTPTSs62mCLzk0QWxdXT/AbKKtL3tpMbw7c7IM6Yp5RbnN2sLJ5Vf
F8jNglmHBovukXe0dzhpw9Tfv1BTjrnBVyL3iZ8VdTWIKYVtKJzMAKMFe0FCfqQz
+4etk1BbgBNLOBX5pB9vBPaLXyk+0WnuVQ0466De4fap8BN6Nnw/PO5kx6YXLzYc
MmpSCbKIMif/+OgcbuLSc+sbT31swX7OPR6P+57QcVUSW2jdLF5pxXGKEmt6ZPZt
GX2puHTkETiHpBWZoF6g
=cmxO
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list