[PATCH 2/7] wined3d: Restore the display mode on focus loss (v2).
Stefan Dösinger
stefandoesinger at gmail.com
Mon Oct 6 09:40:44 CDT 2014
Am 06.10.2014 um 15:48 schrieb Henri Verbeet <hverbeet at gmail.com>:
> This seems to imply that if an application created a fullscreen
> swapchain at the current display resolution, but then some external
> mode change happened, we should keep the mode from the external mode
> change on focus loss, but then change it on reset. That may be
> correct, but it's certainly more complicated than just resetting the
> original mode on focus loss, and I don't see tests.
I expect this to just crash and burn on Windows, but I'll check. Where would an external mode change come from without a focus loss?
The purpose of the wined3d_swapchain_mode_changed() is to prevent redundant mode changes, although most drivers seem to gracefully ignore them in practice.
> As a follow up, it
> would perhaps also be interesting to verify that in some of the places
> where we're currently using "original_mode", we really shouldn't be
> using EnumDisplaySettings() with ENUM_REGISTRY_SETTINGS instead.
That sounds like a reasonable thing to test, yeah.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20141006/502df132/attachment.sig>
More information about the wine-devel
mailing list