[PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 2)

[Alexandre Julliard]

Alex Henrie <alexhenrie24 at gmail.com> writes:

> Alexandre stated that he wanted to see more tests for invalid input:
> https://www.winehq.org/pipermail/wine-devel/2012-December/098051.html
>
> The new patchset includes many more tests for invalid input, and
> writing those tests exposed a bug in utf7_mbstowcs which is now fixed.
> The 14 examples in test_utf7_string_conversion add 29 tests which go
> through literally hundreds of code paths.
>
> Alexandre: Please, communicate why you are rejecting the code. This
> issue will drag on and on until we can come to an agreement.

You're still not checking the source len correctly, and you still don't
have any tests for such cases. And no, I don't consider that 14 examples
is a lot of tests. You should be able to do better than that.

-- 
Alexandre Julliard
julliard at winehq.org