[PATCH 1/2] d3d8/tests: Don't check the foreground window if we're not in foreground.

[Henri Verbeet]

On 10 October 2014 08:28, Francois Gouget <fgouget at codeweavers.com> wrote:
> On Wed, 8 Oct 2014, Stefan Dösinger wrote:
> [...]
>> There are many more failures in d3d8:device when the test is not in
>> foreground. Those failures write static lines and I'd prefer the testbot
>> to be changed to run them in foreground instead.
>
> What do you mean by that?
>
> The TestBot runs a command line tool in an iconized console. In turn
> that tool runs the test binary. However I'm not aware of it preventing
> test windows from being in the foreground.
>
> Maybe the console windows being iconized somehow gets inherited by the
> windows created by the test binary, but shouldn't the test just request
> to bring its windows to the foreground?
>
The way I understand it is roughly that the foreground process is the
process that either last received user input, or was launched by the
foreground process, and that SetForegroundWindow() mostly just works
for the foreground process. It may help if the console window isn't
iconized. It's interesting that creating a fullscreen d3d9 device
apparently makes us the foreground process, but it's probably not
something we can do ourselves from the test in the general case.