[PATCH v4 3/8] reg.exe: Add wchar/type conversion functions

Stefan Dösinger stefandoesinger at gmail.com
Sun Oct 12 09:08:29 CDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-09 10:55, schrieb Jonathan Vollebregt:
> +static const WCHAR *type_get_wchar(const DWORD type)
This function is not used. You can add it in patch 5, where you actually use it.

> +static DWORD wchar_get_type(const WCHAR *type)
> +{
> +    static const WCHAR type_dword_le[] = {'R','E','G','_','D','W','O','R','D','_','L','I','T','T','L','E','_','E','N','D','I','A','N',0};
> +    DWORD i;
> +
> +    if (lstrcmpiW(type, type_dword_le) == 0)
> +        return REG_DWORD_LITTLE_ENDIAN;
I think a table where you can map two different strings to index 4 is nicer than the special case, unless having the cheap reverse lookup is important for performance.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUOotdAAoJEN0/YqbEcdMwpsAQAJIoOZIzwfKU+EWf6lTO1L6u
zhHECP7G8GnlxDI9XGVkg0xvj0v+mxBXUXHdWkCczKyuWJFmUB4adULqpXDloyRa
0aMKSnziixXadiQMY5p36KmTSVLg+rCq3ol/dCjR1E/kCktkwbH0mcx0w4YMf9wZ
/gtTRFY7F4OVLFQdhZV4lI2stcJpP057Tx+MivzfpVgw+HXfo3IUZlDtAVY0LNXV
DfjX9terIhqE6kqkyalsa6sYczNRgrGF2D+jU+MADJSnQ7bHk15foayV4nzkcqk9
wabU65qY4HEWTo54m4u/W0yVyEb3j3JWN1XQAm/a+ae1iFnE86XHf5eq7s4ze81a
Wu5dYdBanrH/qMkzGdG15+3h2u33PxHOL0R/25KrwvZDV61GGJ8r1gJEsPvNWqh3
QomLLMPCSArNLBUQSUrfk84GyeOg0TBfSXTR/JLOxG8GtQ/slAWwa/F310tBxSTa
6Csx6aeazHDMrZhgT2W75hMy1eA8GVGCH5ovBl3ThdJB9kkJM6zIQh7UB940TnVA
orZcSXxxKVENO2FTWbeSrsQhjqwwvTL8reRS2T7wZZAQ3J10OI0HXOAIE4hr54wE
j7FA5whN86sLXg4stjLW0ExpzlTHvTKYxQJl7CPILaYMQXwVIIdrgeaV8bi9ko5c
vlir4SrW/E5rfUfxflAx
=eD+7
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list